Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: generate AST instead of SQL for foreign key cascade #38796

Merged
merged 16 commits into from
Nov 4, 2022
Merged

executor: generate AST instead of SQL for foreign key cascade #38796

merged 16 commits into from
Nov 4, 2022

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Issue Number: close #38795

Problem Summary: This PR use generate AST instead of SQL for foreign key cascade

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
executor: use generate ast instead SQL for foreign key cascade
825b59d 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • you06

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 1, 2022
@crazycs520 crazycs520 requested a review from ekexium November 2, 2022 08:56
ekexium
ekexium reviewed Nov 2, 2022
View reviewed changes
executor/foreign_key.go Outdated Show resolved Hide resolved
@crazycs520
address comment
f95a2b9 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
add comment
bd435a5 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Merge branch 'master' into fk-cascade-ast
da040d4
@crazycs520
Copy link
Contributor Author

/run-all-tests

AilinKid
AilinKid reviewed Nov 3, 2022
View reviewed changes
executor/adapter.go Outdated Show resolved Hide resolved
executor/foreign_key.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 4, 2022
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: edfde5a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2022
@crazycs520
Copy link
Contributor Author

/merge

@crazycs520
make bazel_prepare
c45b645 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2022
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0cdb70f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2022
@ti-chi-bot ti-chi-bot merged commit e5d3195 into pingcap:master Nov 4, 2022
@crazycs520 crazycs520 deleted the fk-cascade-ast branch November 4, 2022 03:12
@sre-bot
Copy link
Contributor

sre-bot commented Nov 4, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 16, total 17 18 min New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 5, success 34, total 39 27 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 11 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 2, success 4, total 6 5 min 4 sec Existing failure
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 54 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 46 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 32 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 16 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 55 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekexium ekexium ekexium approved these changes

@AilinKid AilinKid AilinKid approved these changes

@you06 you06 you06 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use generate ast instead of SQL for foreign key cascade
6 participants
@crazycs520 @ti-chi-bot @sre-bot @you06 @AilinKid @ekexium